closed livingstoneonline/livingstoneonline#209

Missing menu for Final Manuscripts

awisnicki

Also the level two boxes for this edition is again not rendering correctly:

screen shot 2017-09-14 at 13 11 26

nigelgbanks

What is the issue? It looks the same as it did on stage the previous week (I haven't the theme code changed the grid theme code since the last round of feedback on stage).

nigelgbanks

Is it the height of the last item (it appears taller than the others)?

nigelgbanks

Looks like it was the image file I uploaded (was the wrong size) should be sorted now.

awisnicki

Yes, indeed, it's sorted now.

nigelgbanks

K the menu is in place now, although still have issue 208 to contend with

awisnicki

Sorry, I'm not clear by what you mean by adding the menu.

I see two issues, but this may be different from this:

  1. The Final Manuscripts edition does not appear in the top menu.
  2. All the pages but the home page don't have the Critical Edition dropdown.
nigelgbanks

The other two issues, have been handled as well.

awisnicki

Looks good. Thank you! Note that the Final Manuscripts dropdown includes the "TEI Encoding Guidelines" twice. The first iteration points to the following external page: http://livingstoneonline.github.io/LEAP-ODD/leap.html This iteration can be removed so that there is only the one point to the new internal guidelines page you created.

nigelgbanks

Should be sorted now.

awisnicki

OK, looks good. Thank you!

awisnicki

Yes, looks good. Thank you. If I find any other instances of this once we move to prod, I'll just fix this myself.

awisnicki

Yes, looks good. Thank you.