closed livingstoneonline/livingstoneonline#232

Minor bugs found in full site review

awisnicki

I've finished my full review of the stage site against prod and only found a few minor issues, as follows:

1) A handful of pages are not rendering in-text images. See attached zip. You can use the breadcrumbs in the screenshots to identify the pages.

Pages-with-missing-images.zip

Here's an example:

screen shot 2017-10-14 at 14 41 22

2) The following pages are rendering H4 tags incorrectly (this might be an issue on other pages, but I only noticed these): http://livingstonestage.lib.umd.edu/spectral-imaging/1871-edition-guide http://livingstonestage.lib.umd.edu/spectral-imaging/tei-p5-encoding-guidelines

Here's an example:

screen shot 2017-10-14 at 14 08 50

3) The line spacing on the captions on the following page is double what it should be. I looked in the coding and don't see the issue (this might be an issue on other pages, but I only noticed these): http://livingstonestage.lib.umd.edu/spectral-imaging/livingstones-1871-field-diary

Here's an example:

screen shot 2017-10-14 at 13 56 08

4) The table on this page is not quite rendering properly (compare against prod): http://livingstonestage.lib.umd.edu/spectral-imaging/terminology-and-acronyms

5) I noticed one small theming issue. In the overview text, when there is no table of contents, the spacing between the overview text and gray line beneath is too large:

screen shot 2017-10-14 at 13 28 10

awisnicki

P.S. If there's anything I can take care of from the issues above, just let me know. For instance, I haven't examined, but I suspect no. 1 is just to do with copies of those images not being in the relevant section page folders.

nigelgbanks

All the above issues should now be sorted.

awisnicki

Yes, everything looks fixed. Thank you very much!