I've had some success with the 'let-stand' metamark issue. Convert the file 'let-stand tests' in the github folder to have a look. The first line is just for comparison (a 'flag' metamark) so the second is the one to look at.
As you can see, I've gotten the dashed underline I wanted (success!), but it's currently outputting duplicate text. This is something that one commenter on stack overflow warned about. On the anchor tag, a bracket is also appearing, which is only supposed to appear for 'reorder' and 'flag' (i.e. as it does in the first line of xml). I suspect this will be easy to fix in the anchor template, though I didn't have any luck.
You can see what I've done in the xslt file from lines 1272-1289. I also introduced <xsl:text>
</xsl:text> in line 44 under <xsl:template match="/"> as the instructions on stack overflow suggested. The relevant lines in css are 699-701.
Yes, managed to solve the duplicate issue. I've also managed to get the let-stand metamark appearing in different colours, red and gray, though the appearance is a little off in my view. I imagine there's a more elegant way to do this in xslt than the way I have, but you can see what I've done in lines 1274-1293. The relevant css lines are 699-707.
I'm still unable to remove the bracket on the anchor, without ruining the brackets for 'flag' and 'reorder'
Well done! Very exciting step forward. I'm happy to take a crack at the remaining issues with this, if you set up some specific examples in the test files and give me instructions on what you need.
Great. I've set up a number of test cases in the file 'let-stand tests'. At the start of the file are examples of 'flag' and 'reorder' metamark, which should remain unchanged with any coding updates.
Here are the problems that are currently appearing with 'let-stand'.
1) A bracket is appearing on the anchor tag. This is because a bracket is supposed to appear for 'flag' and 'reorder'. I can't work out how to stop it for 'let-stand' while retaining it for the other two.
2) The dashed red and dashed gray underlines are mixed with black for some reason. This isn't a huge concern, but it would be better if this didn't happen.
3) Ideally I'd like a title on 'let-stand', since I have on the other metamarks. But the way this metamark is set up is a bit different to the others and I can't get it to accept a title.
Resync.
For 1, I simply created a template that addresses this specific issue and removes the bracket. See if you can start with this, then do some more modifying to get it to work exactly how you want it.
For 3, This is now fixed and the pop up text is there for every instance. In some cases, it's trumped by other coding and so doesn't pop up, but if you look at the source code of the HTML file you'll see that it's there in every instance, so this is resolved.
Note: I have no idea why the size of the font changes as one goes down the page, do you?
Let's come back to 2 once 1 and 3 are fully resolved.
Great, thanks Adrian. I've made some further changes, so resync.
We can now consider 1 and 3 resolved. I think removing the bracket as you have done is enough, since 'flag' and 'reorder' are unaffected. And I've changed the title to the one I want.
As for the font size issue, it was being caused by the metamarks being set to 1.1em in css. I resolved this in section 12 of the file by creating specific cases for 'dashed' beside a metamark i.e. .dashed .metamark which has done the trick. Does that look alright?
This appears to be coming, in part, from line 1300 of the xsl. That turns off the dashed-gray line, but I'm sure messes up something else. However, there's also a dotted gray line. Resync and see what happens when I comment out 1300. Can you make out what is being enacted here, ie.., which templates are coming into play.
Resync and generate a new HTML file. I identified the issue. Basically, each preceding metamark is not being turned off (or maybe it's the anchor -- the point is that one of these two is not turning off) when a new one appears, so for subsequent ones the coding piles up. I've put each separate instance of a metamark/anchor its own paragraph and now it appears fine (I think). I think we encountered this issue of a tag not being turned off before, but at this stage I can't remember how we fixed it. Do you?
OK, I've come up with a TOTAL hack to fix this. Basically, what I've done is hard coded two closing tags (only) to appear for the two spans that are not closing (metamark and anchor). Sync and take a look. This is contraindicated and you'll need to test it across files, but it does do the trick here, so may be what we need. P.S. Ignore what I did to the XML file and all you need to look at is my most recent change to the xsl file.
Brilliant. I've tested this on lots of files and it looks perfect. You'll need to explain to me exactly how this works when we speak, though I think I sort of grasp it. Really good to get this sorted. Thanks!!
I've had some success with the 'let-stand' metamark issue. Convert the file 'let-stand tests' in the github folder to have a look. The first line is just for comparison (a 'flag' metamark) so the second is the one to look at.
As you can see, I've gotten the dashed underline I wanted (success!), but it's currently outputting duplicate text. This is something that one commenter on stack overflow warned about. On the anchor tag, a bracket is also appearing, which is only supposed to appear for 'reorder' and 'flag' (i.e. as it does in the first line of xml). I suspect this will be easy to fix in the anchor template, though I didn't have any luck.
You can see what I've done in the xslt file from lines 1272-1289. I also introduced
<xsl:text>
</xsl:text>
in line 44 under<xsl:template match="/">
as the instructions on stack overflow suggested. The relevant lines in css are 699-701.think I've solved the duplicate text issue. Hang on for further updates...
Yes, managed to solve the duplicate issue. I've also managed to get the let-stand metamark appearing in different colours, red and gray, though the appearance is a little off in my view. I imagine there's a more elegant way to do this in xslt than the way I have, but you can see what I've done in lines 1274-1293. The relevant css lines are 699-707.
I'm still unable to remove the bracket on the anchor, without ruining the brackets for 'flag' and 'reorder'
Well done! Very exciting step forward. I'm happy to take a crack at the remaining issues with this, if you set up some specific examples in the test files and give me instructions on what you need.
Great. I've set up a number of test cases in the file 'let-stand tests'. At the start of the file are examples of 'flag' and 'reorder' metamark, which should remain unchanged with any coding updates.
Here are the problems that are currently appearing with 'let-stand'.
1) A bracket is appearing on the anchor tag. This is because a bracket is supposed to appear for 'flag' and 'reorder'. I can't work out how to stop it for 'let-stand' while retaining it for the other two. 2) The dashed red and dashed gray underlines are mixed with black for some reason. This isn't a huge concern, but it would be better if this didn't happen. 3) Ideally I'd like a title on 'let-stand', since I have on the other metamarks. But the way this metamark is set up is a bit different to the others and I can't get it to accept a title.
Resync. For 1, I simply created a template that addresses this specific issue and removes the bracket. See if you can start with this, then do some more modifying to get it to work exactly how you want it. For 3, This is now fixed and the pop up text is there for every instance. In some cases, it's trumped by other coding and so doesn't pop up, but if you look at the source code of the HTML file you'll see that it's there in every instance, so this is resolved. Note: I have no idea why the size of the font changes as one goes down the page, do you? Let's come back to 2 once 1 and 3 are fully resolved.
Great, thanks Adrian. I've made some further changes, so resync.
We can now consider 1 and 3 resolved. I think removing the bracket as you have done is enough, since 'flag' and 'reorder' are unaffected. And I've changed the title to the one I want.
As for the font size issue, it was being caused by the metamarks being set to 1.1em in css. I resolved this in section 12 of the file by creating specific cases for 'dashed' beside a metamark i.e.
.dashed .metamark
which has done the trick. Does that look alright?Now for number 3!
This appears to be coming, in part, from line 1300 of the xsl. That turns off the dashed-gray line, but I'm sure messes up something else. However, there's also a dotted gray line. Resync and see what happens when I comment out 1300. Can you make out what is being enacted here, ie.., which templates are coming into play.
Resync and generate a new HTML file. I identified the issue. Basically, each preceding metamark is not being turned off (or maybe it's the anchor -- the point is that one of these two is not turning off) when a new one appears, so for subsequent ones the coding piles up. I've put each separate instance of a metamark/anchor its own paragraph and now it appears fine (I think). I think we encountered this issue of a tag not being turned off before, but at this stage I can't remember how we fixed it. Do you?
OK, I've come up with a TOTAL hack to fix this. Basically, what I've done is hard coded two closing tags (only) to appear for the two spans that are not closing (metamark and anchor). Sync and take a look. This is contraindicated and you'll need to test it across files, but it does do the trick here, so may be what we need. P.S. Ignore what I did to the XML file and all you need to look at is my most recent change to the xsl file.
Brilliant. I've tested this on lots of files and it looks perfect. You'll need to explain to me exactly how this works when we speak, though I think I sort of grasp it. Really good to get this sorted. Thanks!!
Awesome!